gh-137578: support top-level setup statements in Timer objects
#137587
Conversation
picnixz
force-pushed
the
feat/timeit/global-setup-137578
branch
from
26c22fd to
a63c5f1
Compare
| *stmt*, *setup* and *global_setup* may also contain multiple statements | ||
| separated by ``;`` or newlines, as long as they don't contain multi-line | ||
| string literals. |
There was a problem hiding this comment.
I know this has been in the docs for a while, but why aren't multi-line strings allowed? A quick test shows the implementation allows them, though I suppose strings inside stmt or setup may get indented differently than the user intends.
There was a problem hiding this comment.
Because we reindent the user's code by replacing \n (it's a naive reindentation, not based on textwrap and possibly because of historical reasons). Maybe we should instead use dedent() followed by indent(), in which case that could be ok I guess. However, this should be a separate issue.
There was a problem hiding this comment.
Hm, at least for the new global_setup that doesn't apply. But even for the existing parameters I'm not sure multi-line strings are prohibited as the docs suggest or just may produce unexpected results (due to reindenting). Regardless we can open a separate issue to discuss a docs change.
- carry co_flags obtained from global setup - update timeit() and repeat() functions
timeit#137578📚 Documentation preview 📚: https://cpython-previews--137587.org.readthedocs.build/